Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: added badges support #1372

Merged
merged 2 commits into from
Jul 24, 2023
Merged

github: added badges support #1372

merged 2 commits into from
Jul 24, 2023

Conversation

anikachurilova
Copy link
Contributor

anikachurilova
anikachurilova commented Jul 21, 2023
View reviewed changes
invenio_rdm_records/services/github/release.py
self.release_file_name,
file_stream,
uow=uow,
draft = current_rdm_records_service.update_draft(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was: in the update_draft there's a validation which was failing because "files": {"enabled": True},, but no files are provided yet (it was happening after draft update).

What was done: moved file addition before draft update

@zzacharo zzacharo merged commit 3818b79 into inveniosoftware:master Jul 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzacharo zzacharo zzacharo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: update badges to new module's
3 participants
@anikachurilova @zzacharo @alejandromumo