service: fix restore/delete of specific record version #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
versions-management
branch
2 times, most recently
from
dd6d2e9
to
485c2a9
Compare
zzacharo
commented
Oct 9, 2023
| @@ -258,9 +273,23 @@ def restore_record(self, identity, id_, expand=False, uow=None): | |||
| # Run components | |||
| self.run_components("restore_record", identity, record=record, uow=uow) | |||
|
|
|||
| # set latest to the previous non deleted record | |||
| latest_record_version = self.record_cls.get_latest_by_parent(record.parent) | |||
There was a problem hiding this comment.
I should filter based on deletion_status
zzacharo
force-pushed
the
versions-management
branch
from
485c2a9
to
1f56cbb
Compare
zzacharo
force-pushed
the
versions-management
branch
from
9f4bf67
to
dbefb26
Compare
zzacharo
force-pushed
the
versions-management
branch
from
dbefb26
to
259975d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1522
requires inveniosoftware/invenio-drafts-resources#259