datacite: fix related identifiers serialization. #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
reviewed
Oct 27, 2023
| @@ -362,7 +385,8 @@ def get_related_identifiers(self, obj): | |||
| default=scheme, | |||
| ) | |||
|
|
|||
| if id_scheme: | |||
| # Only serialize related identifiers with a valid scheme for DataCite. | |||
| if id_scheme and id_scheme.lower() in RELATED_IDENTIFIER_SCHEMES: | |||
There was a problem hiding this comment.
minor: instead of that would it make sense to:
- remove the
"datacite": "Other"value from theRDM_RECORDS_IDENTIFIERS_SCHEMESconfig (we only need "valid" DataCite values there) - change it so that the
get_scheme_datacitecalls are a bit more strict? Right now I seedefault=schemebeing passed in many places, which is wrong. We want to enforce that if there is not equivalent DataCite scheme for an identifier, it has to be skipped.
There was a problem hiding this comment.
I added a task to tackle the invalid schemes.
We have more schemes that don't map to DataCite's related identifiers (e.g. crossreffunderid)
slint
reviewed
Oct 27, 2023
invenio_rdm_records/config.py
Outdated
| @@ -94,7 +94,6 @@ def always_valid(identifier): | |||
| "url": {"label": _("URL"), "validator": idutils.is_url, "datacite": "URL"}, | |||
| "urn": {"label": _("URN"), "validator": idutils.is_urn, "datacite": "URN"}, | |||
| "w3id": {"label": _("W3ID"), "validator": always_valid, "datacite": "w3id"}, | |||
There was a problem hiding this comment.
Will it be that now all IDs will be identified as w3id, since it's the last entry with always_valid?
I'm not sure what the logic for scheme detecting is for related identifiers...
There was a problem hiding this comment.
I had a quick look and it seems that this "fallback" does not happen, but I want to be more thorough with the analysis. I will do it in a separate task so we can unblock the fix for now
alejandromumo
force-pushed
the
fix_datacite_related_identifiers
branch
from
88ca365
to
0fc2be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/zenodo/rdm-project/issues/472