Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: move record_once to finalize_app #258

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

utnapischtim
Copy link
Contributor

No description provided.

@utnapischtim utnapischtim marked this pull request as ready for review July 25, 2023 08:03
@utnapischtim utnapischtim marked this pull request as draft July 25, 2023 08:04
@utnapischtim utnapischtim marked this pull request as ready for review July 25, 2023 08:05
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready for merge + release, but not until we find a low-impact candidate module first.

* pytest-black seems out of support. the last commit was from
  2020-10-05. Further pytest-black uses a out of date method which
  mentions pytest>=7.0 with a DeprecationWarning. The simplest solution
  is to use pytest-black-ng which fixes this situation.
@kpsherva kpsherva merged commit 7eb7fbb into inveniosoftware:master Mar 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants