Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MeshGenerator and efficient rendering methods #77

Merged
merged 18 commits into from
Dec 10, 2024
Merged

Add MeshGenerator and efficient rendering methods #77

merged 18 commits into from
Dec 10, 2024

Conversation

lioutasb
Copy link
Member

No description provided.

@lioutasb lioutasb changed the title Add MeshGenerate and efficient rendering methods Add MeshGenerator and efficient rendering methods Nov 29, 2024
adscib
adscib approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@adscib adscib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's not really practical for me to check the code carefully, so I think we'll just test it all together with the other changes.

torchdrivesim/mesh.py Show resolved Hide resolved
@lioutasb lioutasb marked this pull request as ready for review December 10, 2024 21:53
@lioutasb lioutasb merged commit 755fcbb into remove-agent-functor Dec 10, 2024
0 of 8 checks passed
@lioutasb lioutasb deleted the efficient_rendering branch December 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adscib adscib adscib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lioutasb @adscib