Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users with report permissions to have dashboard visibility. #1959

Open
ttytm opened this issue Aug 6, 2024 · 8 comments
Open

Allow users with report permissions to have dashboard visibility. #1959

ttytm opened this issue Aug 6, 2024 · 8 comments

Comments

@ttytm
Copy link

ttytm commented Aug 6, 2024

Screenshot_20240807_014253

Repro:

  • Ensure there is an entry whose data should be displayed on the dashboard.
  • Verify that it is visible as an admin.
  • Try to display it with a non-admin user.
@turbo124
Copy link
Member

turbo124 commented Aug 7, 2024

If a user is not an administrator, they will only see the data of the records that they create.

@turbo124 turbo124 closed this as completed Aug 7, 2024
@ttytm
Copy link
Author

ttytm commented Aug 7, 2024

Thanks for the swift response @turbo124 .

This means that with this UI implementation it is not possible for a user who is not an administrator to get an overview of all invoices on the dashboard, but it possible to create reports for all of them?

This seems to be an inconsistent design decision. Is there a rationale for this?

@turbo124
Copy link
Member

turbo124 commented Aug 7, 2024

@ttytm we added the Reports/Dashboard permission levels after the view/edit/create permission levels based on feedback from users.

Whilst you make a valid point about the raw data still being accessible if reports are enabled the dashboard remains out of view based on some users preference.

@ttytm
Copy link
Author

ttytm commented Aug 7, 2024

Is there a chance to add a permission option that would allow viewing the data on the dashboard when it is set?

@turbo124
Copy link
Member

turbo124 commented Aug 7, 2024

It can be a feature request, but in this scenario , most people would just use the administrator permission.

@ttytm
Copy link
Author

ttytm commented Aug 7, 2024

Yes i think so too, it'll be the usual case. It was just a case I encountered where it would be more appropriate without promoting to admin rights. Thanks again.

@ttytm
Copy link
Author

ttytm commented Aug 17, 2024

@turbo124, I hope I’m not bothering you too much. Would this be considered a feature request for the main repo then?

Since there is quite a gap between allowing a user to view full graphs vs promoting them to an admin, which grants access to more critical settings, allowing to create/delete organizations etc., I believe it would be appropriate to have a separate permission option for allowing users to view the graph/stats for an account.

@turbo124 turbo124 reopened this Aug 18, 2024
@turbo124 turbo124 changed the title Dashboards for non-admin users are corrupted (graphs / numbers not working) Allow users with report permissions to have dashboard visibility. Aug 18, 2024
@turbo124
Copy link
Member

@ttytm sure, i've set this as a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants