Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notificationforandroidtv to latest #3164

Closed
wants to merge 1 commit into from
Closed

Add notificationforandroidtv to latest #3164

wants to merge 1 commit into from

Conversation

DNAngelX
Copy link
Contributor

@DNAngelX DNAngelX commented Jan 2, 2024

Please add my adapter ioBroker.notificationforandroidtv to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Jan 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

Automated adapter checker

ioBroker.notificationforandroidtv

Downloads Number of Installations (latest)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W400] Cannot find "notificationforandroidtv" in latest repository

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 added the (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. label Jan 2, 2024
@DNAngelX
Copy link
Contributor Author

DNAngelX commented Jan 2, 2024

https://forum.iobroker.net/topic/71123/neuer-adapter-android-tv-fire-tv-benachrichtigungen/24?_=1704149932016

Hi,
hier laeuft der Adapter ohne Fehler, sendet alle Messages mit&ohne Bild, alles einwandfrei. Kann von meiner Seite als Anwender ins Stable.
Getestet mit iobroker Buanet Docker V9.0.1, Node 18.19.0, NPM 10.2.3, js-controller 5.0.17, verschiedene FireTV Sticks.

@github-actions github-actions bot added the *📬 a new comment has been added label Jan 2, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 2, 2024

Kann von meiner Seite als Anwender ins Stable.

The adapter will get a (manual) review before adding it to LATEST repository (as requested by this PR) first. If there are any commants / suggestions you will get a feedback here. Please be patient as this may last a (short) time depending on available time.

If there are no problems detected during availability at latest you may request addition to stable.
See https://github.com/ioBroker/ioBroker.repositories?tab=readme-ov-file#iobrokerrepositories for general rules.

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jan 2, 2024
@DNAngelX DNAngelX closed this Jan 8, 2024
@DNAngelX DNAngelX deleted the notificationforandroidtv-to-latest branch January 8, 2024 23:45
@DNAngelX DNAngelX restored the notificationforandroidtv-to-latest branch January 8, 2024 23:45
@DNAngelX DNAngelX deleted the notificationforandroidtv-to-latest branch January 8, 2024 23:47
@mcm1957 mcm1957 removed auto-checked This PR was automatically checked for obvious criterias (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. labels Jan 9, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 9, 2024

replaced by https://github.com/ioBroker/ioBroker.repositories/pull/3189/files

@mcm1957 mcm1957 mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DNAngelX @mcm1957