Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remeha-home to latest #4034

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

simatec
Copy link
Contributor

@simatec simatec commented Sep 10, 2024

Please add my adapter ioBroker.remeha-home to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Sep 10, 2024
@mcm1957 mcm1957 added (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. New at LATEST labels Sep 11, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Sep 11, 2024

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them.

You will find the results of the review and eventually issues / suggestings as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.
mcm1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

reminder 17.9.2024

@github-actions github-actions bot deleted a comment from mcm1957 Sep 11, 2024
Copy link

Automated adapter checker

ioBroker.remeha-home

Downloads - Test and Release
NPM

👍 No errors found

  • 👀 [W401] Cannot find "remeha-home" in latest repository

Add comment "RE-CHECK!" to start check anew

@github-actions github-actions bot deleted a comment from mcm1957 Sep 18, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Sep 18, 2024

@simatec

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.

  • Readme.md should contain a link to the manufacturer and/or device

    The README.md of any adapter related to device or m ultiple devices of a manufacturer should contain a link the manufacturers website and/or to a description of the device. This is to anable new users to easily check wether they associate the adapter with the correct device(s). (See https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository paragraph 4.)

  • reevaluate state roles

    Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.

    In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully. States with role 'button' should (must) have attribute 'common.read=false' set. A button ( "Taster" in german only triggers when you press but else has no state), so it should also be not readable. This is also like HomeMatic does it. A switch has clear states true or false and so can be read.

    data.roomThermostat.setPoint is writeable, so it must have role level.temperature.
    https://github.com/simatec/ioBroker.remeha-home/blob/1f411cd6bfe3d62596c4222a3c5478cbbeb9261e/main.js#L130

  • adapt testing to supported node releases

    Tests for node 18 are mandatory as this is the recommended node version unless you require node 20 minimum.
    Tests for node 20 are mandatory as this is the recommended node version.
    Tests for node 21 are mandatory unless you already know incompatibilities which cannot be fixed immidiatly. In this case please create a issue stating the problem and fix as soon as possible.

    So the recommended testmatrix is [18.x, 20.x, 22.x] depending on engines requirments setting at package.json

    Tests must be performed at all supported platforms (linux, windows, mac) unless special hardware or software restrictions prohibit this.

Thanks for reading and evaluating this suggestions.
McM1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

reminder 28.9.2024

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review and removed (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. labels Sep 18, 2024
@simatec
Copy link
Contributor Author

simatec commented Sep 18, 2024

all done...

@github-actions github-actions bot added the *📬 a new comment has been added label Sep 18, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Sep 18, 2024

all done...

WAU - faster then light!
Thanks - I'm a little bit slower :-(

@mcm1957 mcm1957 added lgtm Looks Good To Me and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Sep 18, 2024
@mcm1957 mcm1957 merged commit cb64828 into ioBroker:master Sep 18, 2024
31 checks passed
@mcm1957
Copy link
Collaborator

mcm1957 commented Sep 18, 2024

This adapter has been released to latest repository and should be visible within 24h maximum.

Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.

Note: If an other testing topic already exists, it' OK to continue using this topic too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias lgtm Looks Good To Me New at LATEST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants