Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sun2000-modbus to latest #3007

Closed
wants to merge 2 commits into from
Closed

Add sun2000-modbus to latest #3007

wants to merge 2 commits into from

Conversation

daolis
Copy link
Contributor

@daolis daolis commented Nov 28, 2023

Please add my adapter ioBroker.sun2000-modbus to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Nov 28, 2023
@mcm1957 mcm1957 added the (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. label Nov 28, 2023
@daolis
Copy link
Contributor Author

daolis commented Nov 28, 2023

@mcm1957 JFYI This is the new one, but same errors from ioBroker.bosesoundtouch and ioBroker.sonnen-charger

@github-actions github-actions bot added the *📬 a new comment has been added label Nov 28, 2023
@daolis
Copy link
Contributor Author

daolis commented Nov 28, 2023

ahh, oops, missed that you added the pending labe already... 🙈

@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 28, 2023

No problem.

Please ignore the other adpters. I'll check as soon as I have time. Currently no action required by you

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Nov 28, 2023
This was referenced Dec 6, 2023
Closed
Closed
@github-actions github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Dec 6, 2023
@github-actions github-actions bot deleted a comment from mcm1957 Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Automated adapter checker

ioBroker.bosesoundtouch

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E114] No adapter are allowed in the repo without admin support (set "common.noConfig = true" and "common.adminUI.config = none" if adapter has no configuration)
  • ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2019-2023 sven_s_ter sven_s_ter@icloud.com" at the end of README.md
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2019-2023 sven_s_ter sven_s_ter@icloud.com" at the start of LICENSE
  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)

ioBroker.sonnen-charger

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

ioBroker.sun2000-modbus

Downloads Number of Installations (latest)
NPM

👍 No errors found

  • 👀 [W400] Cannot find "sun2000-modbus" in latest repository

ioBroker.beckhoff

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

ioBroker.ds18b20

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.emby

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E506] Word "Timeout" is not translated to russian in admin/words.js. You can use https://translator.iobroker.in/ for translations
  • ❗ [E506] Word "TimeoutDesc" is not translated to russian in admin/words.js. You can use https://translator.iobroker.in/ for translations
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)

ioBroker.envertech-pv

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.gira-iot

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.lifx

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E518] "@alcalzone/release-script" is used, but ".releaseconfig.json" not found
  • 👀 [W171] "common.title" is deprecated in io-package.json

ioBroker.mqtt-client

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W505] setTimeout found in "main.js", but no clearTimeout detected

ioBroker.nsclient

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

ioBroker.procon-ip

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 Yannic Labonte yannic.labonte@gmail.com" at the start of LICENSE
  • 👀 [W505] setTimeout found in "build/main.js", but no clearTimeout detected

ioBroker.pylontech

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

ioBroker.tibberlink

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.tractive-gps

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

ioBroker.vis-icontwo

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

ioBroker.welcome

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E802] No topics found in the repository. Please go to "https://github.com/ioBroker/ioBroker.welcome", press the settings button beside the about title and add some topics.
  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
  • 👀 [W505] setTimeout found in "main.js", but no clearTimeout detected

ioBroker.boschindego

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W515] Why you decided to disable i18n support?

ioBroker.opensmartcity

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

ioBroker.pid

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

ioBroker.reolink

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.solaredge

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.vis-2-widgets-sweethome3d

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

  • ❗ [E114] No adapter are allowed in the repo without admin support (set "common.noConfig = true" and "common.adminUI.config = none" if adapter has no configuration)
  • ❗ [E162] onlyWWW should have common.mode "none" in io-package.json
  • ❗ [E124] Main file not found under URL: https://raw.githubusercontent.com/ioBroker/ioBroker.vis-2-widgets-sweethome3d/main/main.js
  • ❗ [E519] "main.js" found in package.json, but not found as file
  • ❗ [E802] No topics found in the repository. Please go to "https://github.com/ioBroker/ioBroker.vis-2-widgets-sweethome3d", press the settings button beside the about title and add some topics.
  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 mentioned this pull request Dec 6, 2023
Merged
@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 6, 2023

replaced by #3038

@mcm1957 mcm1957 added duplicate and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. labels Dec 6, 2023
@mcm1957 mcm1957 closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-checked This PR was automatically checked for obvious criterias duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daolis @mcm1957