Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e3oncan to 0.9.5 #4113

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

MyHomeMyData
Copy link
Contributor

Please update my adapter ioBroker.e3oncan to version 0.9.5.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Automated adapter checker

ioBroker.e3oncan

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

Adapter releases: https://www.iobroker.dev/adapter/e3oncan/releases
Adapter statistic: https://www.iobroker.dev/adapter/e3oncan/statistics

History and usage information for release 0.9.5:

0.9.5 created 19.9.2024 (11 days old)
4 users (9.52%)

0.9.4 (stable) created 26.8.2024 (35 days old)
17 users (stable) (40.48%)

Please verify that this PR really tries to update to release 0.9.5!

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 1, 2024

@MyHomeMyData
Please activate nodeJs 22 tests - unless you know there is a problem.

A new release is NOT required, but tests should pass with GH head

@mcm1957 mcm1957 added the ON HOLD PR is set ON HOLD due to pending question or major issues. label Oct 1, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 1, 2024

reminder 8.10.2024

@MyHomeMyData
Copy link
Contributor Author

Adapter is running with node 22, but tests fail with node 22. Problem seems to be linked to socketcan.
I'm in clarification about that, issue is still open.

Martin, we had a discussion about that topic via telegram.

I added a note in readme: "Not fully tested with node 22." So from my point of view we should proceed.

@github-actions github-actions bot added the *📬 a new comment has been added label Oct 1, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 1, 2024

Sorry - I missed this.
Too much issues every day ...

@mcm1957 mcm1957 removed ON HOLD PR is set ON HOLD due to pending question or major issues. *📬 a new comment has been added labels Oct 1, 2024
@mcm1957 mcm1957 merged commit 4f3cc67 into ioBroker:master Oct 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants