Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TeslaFi Adapter to latest repository #4236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hombach
Copy link
Contributor

@hombach hombach commented Oct 28, 2024

No description provided.

@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Oct 28, 2024
@github-actions github-actions bot deleted a comment from hombach Oct 28, 2024
@mcm1957 mcm1957 added (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. New at LATEST and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Oct 29, 2024
@github-actions github-actions bot added *📬 a new comment has been added 4.11.2024 labels Oct 29, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Oct 29, 2024
@simatec
Copy link
Contributor

simatec commented Oct 30, 2024

jsonConfig looks good...

@github-actions github-actions bot added the *📬 a new comment has been added label Oct 30, 2024
@github-actions github-actions bot added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review and removed 4.11.2024 labels Nov 1, 2024
@github-actions github-actions bot deleted a comment from mcm1957 Nov 1, 2024
@hombach hombach closed this Nov 1, 2024
@hombach hombach reopened this Nov 1, 2024
@github-actions github-actions bot deleted a comment from hombach Nov 1, 2024
@hombach
Copy link
Contributor Author

hombach commented Nov 1, 2024

"xs" should specify a value of "12" at admin/jsonConfig.json/items/_StandardTab/_donate -> has to be 6, otherwise button is too big

I'm no friend of automated translations - so I don't use i18n

@github-actions github-actions bot deleted a comment from mcm1957 Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Automated adapter checker

ioBroker.teslafi

Downloads Number of Installations (latest) - Test and Release
NPM

👍 No errors found

  • 👀 [W401] Cannot find "teslafi" in latest repository
  • 👀 [W522] Why did you decide not to use i18n support?

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 1, 2024

Your TOO fast :-)
Size check has been disabled for divider an staticImage in the meantime. Checks are adjustes to results in real life. :-)

I18n is a warning only which will not be considered blocking.

@hombach
Copy link
Contributor Author

hombach commented Nov 1, 2024

:) - so all this 5 times 12 for dividers could be removed?.... -> next release ;)

... so must be fixed label isn't relevant anymore? Or do I have to change something?

@mcm1957 mcm1957 added New at LATEST and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review *📬 a new comment has been added labels Nov 1, 2024
Copy link

github-actions bot commented Nov 2, 2024

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.
mcm1957

@simatec Please take a look in respect to responsive design. Thanks

@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 5, 2024

Sorry, but due to travel / absence I will not able to do the review before ioBroker Meeting Solingen next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias New at LATEST (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants