Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file handling in tnseq_tools #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allrob23
Copy link

@allrob23 allrob23 commented Oct 1, 2024

This pull request addresses an issue with file handling in the tnseq_tools.py script. The current implementation uses open() without properly closing the file, which could potentially lead to resource leaks.

Changes made:

Replace the direct open() call with a with statement to ensure proper file closure.
Improve code readability and adhere to Python best practices for file handling.

Before:

for line in open(metadata_file):
  ....

After:

with open(metadata_file) as f:
  for line in f:
    ....

Motivation:

While Python's garbage collector will eventually close the file when the file object is no longer referenced, it's generally considered good practice to explicitly close files or use a context manager to ensure they're closed promptly and also avoid resource leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant