feat: use Ionic standalone components #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Nov 29, 2023
| import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing'; | ||
| import { IonicModule } from '@ionic/angular'; | ||
| import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';<% if(!standalone) {%> | ||
| import { IonicModule } from '@ionic/angular';<%} %> |
There was a problem hiding this comment.
IonicModule is only needed for the lazy loaded build
liamdebeasi
commented
Nov 29, 2023
Comment on lines
-13
to
+14
| imports: [IonicModule.forRoot()] | ||
| imports: [IonicModule.forRoot()]<%} %><% if(standalone) {%> | ||
| imports: [<%= classify(name) %><%= classify(type) %>],<%} %> |
There was a problem hiding this comment.
If standalone we need to pass the component in imports. If not standalone we need to pass the component in declarations and IonicModule in imports.
liamdebeasi
commented
Nov 29, 2023
| @@ -3,7 +3,8 @@ import { Component, OnInit } from '@angular/core'; | |||
| @Component({ | |||
| selector: '<%= selector %>', | |||
| templateUrl: './<%= dasherize(name) %>.<%= dasherize(type) %>.html', | |||
| styleUrls: ['./<%= dasherize(name) %>.<%= dasherize(type) %>.<%= styleext %>'], | |||
| styleUrls: ['./<%= dasherize(name) %>.<%= dasherize(type) %>.<%= styleext %>'],<% if(standalone) {%> | |||
There was a problem hiding this comment.
This wasn't there before, but the application compiled. My understanding is that standalone components should have standalone: true.
liamdebeasi
commented
Nov 29, 2023
| @@ -2,14 +2,14 @@ import { Component, OnInit } from '@angular/core';<% if(routePath) { %> | |||
| import { ActivatedRoute, Params } from '@angular/router';<% } %><% if(standalone) {%> | |||
| import { CommonModule } from '@angular/common'; | |||
| import { FormsModule } from '@angular/forms'; | |||
| import { IonicModule } from '@ionic/angular';<%} %> | |||
| import { IonContent, IonHeader, IonTitle, IonToolbar } from '@ionic/angular/standalone';<%} %> | |||
There was a problem hiding this comment.
This uses actual Ionic standalone components instead of the lazy loaded ones.
sean-perkins
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for generating standalone components and pages was added in 5523f7a. However, this work used the lazy loaded build of Ionic via
IonicModulesince Ionic standalone components did not exist yet.Now that Ionic standalone components have been released, I'd like to update the page/component generation to use Ionic standalone components instead of
IonicModule.Note: You may encounter a
waitForAsyncsyntax error when testing. This is fixed in #505.closes #500