Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Ionic standalone components #504

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat: use Ionic standalone components #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...t/files/__name@dasherize@if-flat__/__name@dasherize__.__type@dasherize__.spec.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
import { IonicModule } from '@ionic/angular';
import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';<% if(!standalone) {%>
import { IonicModule } from '@ionic/angular';<%} %>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IonicModule is only needed for the lazy loaded build

import { <%= classify(name) %><%= classify(type) %> } from './<%= dasherize(name) %>.<%= dasherize(type) %>';

Expand All @@ -8,9 +8,10 @@ describe('<%= classify(name) %><%= classify(type) %>', () => {
let fixture: ComponentFixture<<%= classify(name) %><%= classify(type) %>>;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
TestBed.configureTestingModule({<% if(!standalone) {%>
declarations: [ <%= classify(name) %><%= classify(type) %> ],
imports: [IonicModule.forRoot()]
imports: [IonicModule.forRoot()]<%} %><% if(standalone) {%>
imports: [<%= classify(name) %><%= classify(type) %>],<%} %>
}).compileComponents();
Comment on lines -13 to +14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If standalone we need to pass the component in imports. If not standalone we need to pass the component in declarations and IonicModule in imports.


fixture = TestBed.createComponent(<%= classify(name) %><%= classify(type) %>);
Expand Down
3 changes: 2 additions & 1 deletion ...ponent/files/__name@dasherize@if-flat__/__name@dasherize__.__type@dasherize__.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { Component, OnInit } from '@angular/core';
@Component({
selector: '<%= selector %>',
templateUrl: './<%= dasherize(name) %>.<%= dasherize(type) %>.html',
styleUrls: ['./<%= dasherize(name) %>.<%= dasherize(type) %>.<%= styleext %>'],
styleUrls: ['./<%= dasherize(name) %>.<%= dasherize(type) %>.<%= styleext %>'],<% if(standalone) {%>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't there before, but the application compiled. My understanding is that standalone components should have standalone: true.

standalone: true,<%} %>
})
export class <%= classify(name) %><%= classify(type) %> implements OnInit {

Expand Down
4 changes: 2 additions & 2 deletions packages/schematics/page/files/__name@dasherize@if-flat__/__name@dasherize__.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ import { Component, OnInit } from '@angular/core';<% if(routePath) { %>
import { ActivatedRoute, Params } from '@angular/router';<% } %><% if(standalone) {%>
import { CommonModule } from '@angular/common';
import { FormsModule } from '@angular/forms';
import { IonicModule } from '@ionic/angular';<%} %>
import { IonContent, IonHeader, IonTitle, IonToolbar } from '@ionic/angular/standalone';<%} %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses actual Ionic standalone components instead of the lazy loaded ones.


@Component({
selector: '<%= selector %>',
templateUrl: './<%= dasherize(name) %>.page.html',
styleUrls: ['./<%= dasherize(name) %>.page.<%= styleext %>'],<% if(standalone) {%>
standalone: true,
imports: [IonicModule, CommonModule, FormsModule]<%} %>
imports: [IonContent, IonHeader, IonTitle, IonToolbar, CommonModule, FormsModule]<%} %>
})
export class <%= classify(name) %>Page implements OnInit {<% if(routePath) { %>

Expand Down
Loading