chore: don't hide splash automatically #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
andredestro,
markemer,
EiyuuZack,
Chuckytuh,
theproducer,
dallastjames,
usernuno and
eric-horodyski
Chuckytuh
approved these changes
Oct 22, 2024
markemer
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we install the splash screen plugin but it's not being used because the
launchShowDurationis being set to 0 by default. We have aSplashScreen.hide();call that is not doing anything since the splash screen is not being shown.So replace the
launchShowDuration: 0,withlaunchAutoHide: false,so the splash screen is displayed andSplashScreen.hide();hides it.Alternatively, we can just uninstall the splash screen plugin and remove the code for it.