improve: add jsx fragment factory #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the fragment factory you can't use the `<> ... </>` as a fragment shorthand. If it's set to `Fragment` instead of `h.Fragment`, you'd have to manually import `Fragment` or otherwise you'd get a "Cannot find name 'Fragment'." error. With `h.Fragment`, `<> ... </>` just works. Thanks @ WickyNilliams for the hint!
|
Need to wait for ionic-team/stencil#2846 to be merged and published, then bump the stencil version here as well. |
christian-bromann
requested review from
a team,
rwaskiewicz and
alicewriteswrongs
and removed request for
a team
|
@christian-bromann not sure you saw my previous comment, there's an open PR on Stencil that is required for this to work: ionic-team/stencil#2846. I completely forgot about this, been almost 3 years since I opened it 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the fragment factory you can't use the
<> ... </>as a fragment shorthand. If it's set toFragmentinstead ofh.Fragment, you'd have to manually importFragmentor otherwise you'd get a "Cannot find name 'Fragment'." error. Withh.Fragment,<> ... </>just works.Thanks @WickyNilliams for the hint!