Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store malfunction #73

Open
olivier65 opened this issue Aug 2, 2021 · 11 comments
Open

Store malfunction #73

olivier65 opened this issue Aug 2, 2021 · 11 comments
Labels
Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through.

Comments

@olivier65
Copy link

Stencil version:
stencil-bug1.zip

 @stencil/core@2.6.0
 @stencil/store@1.4.1

I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request
stencil-bug1.zip

Current behavior:
The store is not reactive.

Expected behavior:
The store should work as described in the docs.

Steps to reproduce:
See README.md in the attached zip file, which is a complete project.

@splitinfinities
Copy link
Contributor

Author Solved in ionic-team/stencil#2988

@olivier65
Copy link
Author

olivier65 commented Aug 3, 2021

Please pay attention and reopen this issue!!! What was solved in ionic-team/stencil#2988 is a different issue! I just couldn't be arsed to create separate supporting projects for each.

@splitinfinities
Copy link
Contributor

Apologies, @olivier65, I wasn't sure the repro case. Could you add your .zip file as a github repo instead?

@splitinfinities splitinfinities added Awaiting Reply This PR or Issue needs a reply from the original responder. and removed Resolution: wontfix labels Aug 3, 2021
@olivier65
Copy link
Author

Sigh. Why this fixation on repos when the repo may disappear at some point and the context of the issue be lost? Seems to me that keeping everything self-contained is much preferable. Also, there is no practical difference between git clone and unzip -x. Anyway, the repo is https://github.com/olivier65/stencil-bug1; just ignore the part about Event.

@splitinfinities
Copy link
Contributor

splitinfinities commented Aug 3, 2021

Awesome! Thank you, I appreciate the update and the patience. From what I gather, maybe something about store depends on @State. From what you share, @State is not applied to the consumer, it breaks. When @State is applied, it seems to work. I'm curious if this has something to do with how we minify/treeshake functions out of component definitions.

No timeline on a fix, but I have a better idea of what may be happening. I'll circle back. Thanks again!

Edit: Clarified some stuff

@splitinfinities splitinfinities added Integration: @stencil/store and removed Awaiting Reply This PR or Issue needs a reply from the original responder. labels Aug 3, 2021
@olivier65
Copy link
Author

Maybe a misunderstanding? @State doesn't break the store: on the contrary adding @State somewhere in this project makes the store work, which is hard to explain.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2021

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

@ionitron-bot ionitron-bot bot closed this as completed Sep 3, 2021
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2021
@olivier65 olivier65 mentioned this issue Sep 3, 2021
3 tasks
@rwaskiewicz
Copy link
Contributor

Hey ionitron-bot, we didn't mean to close this. Bad bot!

@rwaskiewicz rwaskiewicz reopened this Sep 3, 2021
@rwaskiewicz rwaskiewicz added the Reply Received The reporter has responded. Stencil team please take a look label Sep 7, 2021
@rwaskiewicz
Copy link
Contributor

👋 As a bit of housekeeping, I'm going to move this issue to the Stencil Store repo

@ionic-team ionic-team unlocked this conversation Feb 16, 2022
@rwaskiewicz rwaskiewicz transferred this issue from ionic-team/stencil Feb 16, 2022
@Serabe
Copy link
Contributor

Serabe commented Feb 16, 2022

@rwaskiewicz this is not solvable on the Stencil Store side. There is already an issue there for this issue: #44

Also, can anyone from Ionic review the PRs there, please?

@rwaskiewicz rwaskiewicz added Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through. and removed Reply Received The reporter has responded. Stencil team please take a look labels Jul 8, 2022
@malarahfelipe
Copy link

This is related to ionic-team/stencil#4135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through.
Projects
None yet
Development

No branches or pull requests

5 participants