-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused dependency npm-watch #224
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that npm-watch
is unused, just wondering if we should also npm i
as part of this PR to also clean up the package-lock.json
at the root of this mono-repo.
Hey @kensodemann , I've updated the |
So are you saying that the |
Weird, the commit showed up a lot longer than the comment. The update to package-lock.json is showing now |
Cool, we can publish to trapezedev now - so whenever you're ready we can merge and publish. Do these tests always fail on CI? |
npm-watch
is not used by the project (and would be a dev dependency if it were), so this PR removes it to address vulunerabilties down the line to @capacitor/assets (ionic-team/capacitor-assets#590)