Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused dependency npm-watch #224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dtarnawsky
Copy link

npm-watch is not used by the project (and would be a dev dependency if it were), so this PR removes it to address vulunerabilties down the line to @capacitor/assets (ionic-team/capacitor-assets#590)

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trapeze ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 7:52pm

Copy link
Member

@kensodemann kensodemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that npm-watch is unused, just wondering if we should also npm i as part of this PR to also clean up the package-lock.json at the root of this mono-repo.

@dtarnawsky
Copy link
Author

Hey @kensodemann , I've updated the package-lock.json after a rebase with the hope that the open source gods will merge this PR to resolve downstream security vulnerabilities.

@kensodemann
Copy link
Member

Hey @kensodemann , I've updated the package-lock.json after a rebase with the hope that the open source gods will merge this PR to resolve downstream security vulnerabilities.

So are you saying that the package-lock.json file is part of an existing change on main then that I cannot see here?

@dtarnawsky
Copy link
Author

dtarnawsky commented Sep 26, 2024

Hey @kensodemann , I've updated the package-lock.json after a rebase with the hope that the open source gods will merge this PR to resolve downstream security vulnerabilities.

So are you saying that the package-lock.json file is part of an existing change on main then that I cannot see here?

Weird, the commit showed up a lot longer than the comment. The update to package-lock.json is showing now

@markemer
Copy link
Contributor

markemer commented Oct 2, 2024

Cool, we can publish to trapezedev now - so whenever you're ready we can merge and publish. Do these tests always fail on CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants