Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the format issue in the CI #1222

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Fix the format issue in the CI #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b12903
call fantomas directly instead of using msbuild target
dawedawe Jan 14, 2024
702f3cb
just check the format
dawedawe Jan 14, 2024
581eaa9
no need to exclude obj directories if we pass in just a directory
dawedawe Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
run: dotnet tool restore

- name: Check format
run: dotnet build -t:CheckFormat
run: dotnet fantomas --check src
env:
DOTNET_ROLL_FORWARD: LatestMajor
DOTNET_ROLL_FORWARD_TO_PRERELEASE: 1
Expand Down
8 changes: 2 additions & 6 deletions Directory.Solution.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
<Project>
<ItemGroup>
<FormatInputs Include="src/**/*.fs;src/**/*.fsi" Exclude="src/**/obj/**/*.fs" />
</ItemGroup>

<Target Name="Format">
<Exec Command="dotnet fantomas @(FormatInputs, ' ') " />
<Exec Command="dotnet fantomas src" />
</Target>

<Target Name="CheckFormat">
<Exec Command="dotnet fantomas --check @(FormatInputs, ' ') " />
<Exec Command="dotnet fantomas --check src" />
</Target>

<ItemGroup>
Expand Down