fix(nack): fix linting issues

ionorg · Nov 19, 2020 · 13e4185 · 13e4185
1 parent 97339f8
commit 13e4185
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/pkg/nack.go b/pkg/nack.go
@@ -20,24 +20,22 @@ type nackList struct {
 	ll    *list.List
 }
 
-func NewNACKList() *nackList {
+func newNACKList() *nackList {
 	return &nackList{
 		nacks: make(map[uint16]*list.Element),
 		ll:    list.New(),
 	}
 }
 
-func (n *nackList) getNACKSeqNo(SN []uint16) []uint16 {
+func (n *nackList) getNACKSeqNo(seqno []uint16) []uint16 {
 	packets := make([]uint16, 0, 17)
-	for _, sn := range SN {
+	for _, sn := range seqno {
 		if nack, ok := n.nacks[sn]; !ok {
 			n.nacks[sn] = n.ll.PushBack(NACK{sn, time.Now().UnixNano()})
 			packets = append(packets, sn)
-		} else {
-			if time.Now().UnixNano()-nack.Value.(NACK).LRX > ignoreRetransmission {
-				nack.Value = NACK{sn, time.Now().UnixNano()}
-				packets = append(packets, sn)
-			}
+		} else if time.Now().UnixNano()-nack.Value.(NACK).LRX > ignoreRetransmission {
+			nack.Value = NACK{sn, time.Now().UnixNano()}
+			packets = append(packets, sn)
 		}
 	}
 

diff --git a/pkg/simplesender.go b/pkg/simplesender.go
@@ -44,7 +44,7 @@ func NewSimpleSender(id string, router *receiverRouter, transceiver *webrtc.RTPT
 	s := &SimpleSender{
 		id:          id,
 		payload:     sender.Track().Codec().PayloadType,
-		nList:       NewNACKList(),
+		nList:       newNACKList(),
 		router:      router,
 		sender:      sender,
 		transceiver: transceiver,

diff --git a/pkg/simulcastsender.go b/pkg/simulcastsender.go
@@ -62,7 +62,7 @@ func NewSimulcastSender(id string, router *receiverRouter, transceiver *webrtc.R
 		router:              router,
 		sender:              sender,
 		transceiver:         transceiver,
-		nList:               NewNACKList(),
+		nList:               newNACKList(),
 		track:               sender.Track(),
 		payload:             sender.Track().Codec().PayloadType,
 		currentTempLayer:    3,