Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0 precision is unintuitive #257

Closed
sproctor opened this issue Feb 11, 2023 · 2 comments
Closed

0 precision is unintuitive #257

sproctor opened this issue Feb 11, 2023 · 2 comments

Comments

@sproctor
Copy link

Describe the bug
The docs claim that 0 means unlimited precision. This isn't true when scale is set. 0 precision is worthless. My suggestion is that when precision is 0 and scale is set in the DecimalMode for an operation, default to max(decimalPrecision, other.decimalPrecision).
@ionspin
Copy link
Owner

ionspin commented Feb 11, 2023

Precision turned out to be an awful API, my idea is to completely drop it in 0.4 and just keep scale or if no scale set unlimited precision

@ionspin
Copy link
Owner

ionspin commented May 8, 2023

I'm closing this as https://github.com/users/ionspin/projects/2 and initial issue #259 has been created to tackle DecimalMode/Scale API.

@ionspin ionspin closed this as completed May 8, 2023
@ionspin ionspin mentioned this issue May 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ionspin @sproctor