Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modInverse and or bitwise function #304

Closed
wants to merge 8 commits into from

Conversation

iTanChi
Copy link

@iTanChi iTanChi commented Jul 8, 2024

Close issues:

The logic is updated and covered by unit test
We have also integrated it with our modules, and it works

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ HoangNguyen219
❌ hieu-dd
You have signed the CLA already but the status is still pending? Let us recheck it.

@ionspin
Copy link
Owner

ionspin commented Jul 8, 2024

Thanks for the pull request, I'll look into it as soon as I have some free time!

@ionspin
Copy link
Owner

ionspin commented Jul 14, 2024

Why is there a github action definition in this pull request?

@iTanChi
Copy link
Author

iTanChi commented Jul 14, 2024

@ionspin our mistake when we want to publish a package for integrating into our module while waiting for your review. We are reverting that commit

@ionspin ionspin closed this Jul 14, 2024
@ionspin
Copy link
Owner

ionspin commented Jul 14, 2024

Ok, please clean up/squash the commits and open a new pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants