Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid rounding #315

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix invalid rounding #315

merged 1 commit into from
Oct 25, 2024

Conversation

ionspin
Copy link
Owner

@ionspin ionspin commented Oct 25, 2024

Remainder was sent as discarded part, which caused invalid rounding in some situations, now the discarded part is calculated so that decider digit can be correctly extracted. Fixes #313

… some situations, now the discarded part is calculated so that decider digit can be correctly extracted. Fixes #313
@ionspin ionspin merged commit e2ec790 into main Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoundingMode ROUND_HALF_AWAY_FROM_ZERO is not returning the expected value
1 participant