Fix Equality Check in XChaCha20EncryptionResult
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `XChaCha20EncryptionResult` data class currently implements its own equality check due to the class's byte array members. However, this is using a standard equality check, `==`, rather than checking the array's contents. This will cause two results with the same contained values to return `false` on an equals check. Confirmed this issue with a unit test, and fixed by changing the implemented method to use `contentEquals` instead.
|
|
|
Nice catch, thanks for the contribution! |
|
Usually the CI would publish the snapshot automatically, but there was a change in Maven Central authentication system and I'll have to update build scripts, and I can do that only in a couple of weeks when I'm back, sorry for the unexpected delay. |
|
Actually I managed to set it up just in time, your changes should be in snapshot version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
XChaCha20EncryptionResultdata class currently implements its own equality check due to the class's byte array members. However, this is using a standard equality check,==, rather than checking the array's contents. This will cause two results with the same contained values to returnfalseon an equals check.Confirmed this issue with a unit test, and fixed by changing the implemented method to use
contentEqualsinstead.