From 42db7a3193638fd6fb7961ec293ec892820ac0ba Mon Sep 17 00:00:00 2001 From: Filipe Fernandes Date: Wed, 14 Aug 2024 17:59:19 +0200 Subject: [PATCH] only has-nczar is needed --- compliance_checker/tests/test_cli.py | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/compliance_checker/tests/test_cli.py b/compliance_checker/tests/test_cli.py index a38a9d65..86ed3390 100644 --- a/compliance_checker/tests/test_cli.py +++ b/compliance_checker/tests/test_cli.py @@ -236,18 +236,9 @@ def _check_libnetcdf_version(): < 8.0 ) - # TODO uncomment the third parameter once S3 support is working - @pytest.mark.skipif( - _check_libnetcdf_version(), - reason="NCZarr support was not available until netCDF version 4.8.0. Please upgrade to the latest libnetcdf version to test this functionality", - ) - @pytest.mark.skipif( - subprocess.check_output(ncconfig + ["--has-nczarr"]) != b"yes\n", - reason="NCZarr is not officially supported for your OS as of when this API was written", - ) @pytest.mark.skipif( subprocess.check_output(ncconfig + ["--has-nczarr"]) != b"yes\n", - reason="NCZarr support was not built with this netCDF version", + reason="NCZarr is not available.", ) @pytest.mark.parametrize( "zarr_url", @@ -256,7 +247,12 @@ def _check_libnetcdf_version(): str(datadir / "zip.zarr"), # "s3://hrrrzarr/sfc/20210408/20210408_10z_anl.zarr#mode=nczarr,s3" ], - ids=["local_file", "zip_file"], # ,'s3_url' + ids=[ + "local_file", + "zip_file", + # TODO uncomment once S3 support is working. + # "s3_url", + ], ) def test_nczarr_pass_through(self, zarr_url): """