Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's skip this one for now #1042

Merged
merged 1 commit into from
Sep 5, 2023
Merged

let's skip this one for now #1042

merged 1 commit into from
Sep 5, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Sep 5, 2023

We should revisit that URL and check if it is back online in the near future. For it is safe to skip so we can get the docs to build again.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1042 (dd9808c) into develop (e456821) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1042   +/-   ##
========================================
  Coverage    82.14%   82.14%           
========================================
  Files           24       24           
  Lines         5170     5170           
  Branches      1292     1292           
========================================
  Hits          4247     4247           
  Misses         623      623           
  Partials       300      300           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 5, 2023

Self-merging this one b/c it is pretty harmless and will unlock new PRs. However, the integration tests are broken again :-/

Seems to be changes in datasets URLs upstream. I'll check them later.

@ocefpaf ocefpaf merged commit 5e19fbb into ioos:develop Sep 5, 2023
9 of 10 checks passed
@ocefpaf ocefpaf deleted the fix_docs branch September 5, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant