Generic Layout Trait

Cargo.toml

@@ -23,6 +23,7 @@ repository = "https://github.com/iosis-tech/cairovm-verifier"
 version = "0.0.1"
 
 [workspace.dependencies]
+bail-out = "0.2.0"
 serde = { version = "1.0", features = ["derive"] }
 serde_with = "2.3.2"
 sha3 = "0.10.8"

crates/air/Cargo.toml

@@ -9,6 +9,7 @@ repository.workspace = true
 version.workspace = true
 
 [dependencies]
+bail-out.workspace = true
 serde.workspace = true
 serde_with.workspace = true
 starknet-crypto.workspace = true

crates/air/src/fixtures/commitment.rs

@@ -1,9 +1,9 @@
 use super::{config, interaction_elements, unsent_commitment};
-use crate::trace::Commitment;
+use crate::{layout::recursive::global_values::InteractionElements, trace::Commitment};
 use cairovm_verifier_commitment::{table, vector};
 use starknet_crypto::Felt;
 
-pub fn get() -> Commitment {
+pub fn get() -> Commitment<InteractionElements> {
     let unsent_commitment = unsent_commitment::get();
     let traces_config = config::get();
 

crates/air/src/layout/mod.rs

@@ -1 +1,74 @@
+use crate::{domains::StarkDomains, public_memory::PublicInput};
+use cairovm_verifier_transcript::transcript::Transcript;
+use starknet_crypto::Felt;
+
 pub mod recursive;
+
+pub trait LayoutTrait {
+    type InteractionElements;
+    fn eval_composition_polynomial(
+        interaction_elements: &Self::InteractionElements,
+        public_input: &PublicInput,
+        mask_values: &[Felt],
+        constraint_coefficients: &[Felt],
+        point: &Felt,
+        trace_domain_size: &Felt,
+        trace_generator: &Felt,
+    ) -> Result<Felt, CompositionPolyEvalError>;
+
+    fn eval_oods_polynomial(
+        column_values: &[Felt],
+        oods_values: &[Felt],
+        constraint_coefficients: &[Felt],
+        point: &Felt,
+        oods_point: &Felt,
+        trace_generator: &Felt,
+    ) -> Felt;
+
+    fn validate(
+        public_input: &PublicInput,
+        stark_domains: &StarkDomains,
+    ) -> Result<(), PublicInputValidateError>;
+
+    fn traces_commit(
+        transcript: &mut Transcript,
+        unsent_commitment: &crate::trace::UnsentCommitment,
+        config: crate::trace::config::Config,
+    ) -> crate::trace::Commitment<Self::InteractionElements>;
+
+    fn traces_decommit(
+        queries: &[Felt],
+        commitment: crate::trace::Commitment<Self::InteractionElements>,
+        decommitment: crate::trace::Decommitment,
+        witness: crate::trace::Witness,
+    ) -> Result<(), crate::trace::decommit::Error>;
+}
+
+use thiserror::Error;
+
+#[derive(Error, Debug)]
+pub enum CompositionPolyEvalError {
+    #[error("segment not present {segment}")]
+    SegmentMissing { segment: usize },
+}
+
+#[derive(Error, Debug)]
+pub enum PublicInputValidateError {
+    #[error("max steps exceeded")]
+    MaxSteps,
+
+    #[error("trace length invalid")]
+    TraceLengthInvalid,
+
+    #[error("segment not present {segment}")]
+    SegmentMissing { segment: usize },
+
+    #[error("layout code invalid")]
+    LayoutCodeInvalid,
+
+    #[error("range_check invalid")]
+    RangeCheckInvalid,
+
+    #[error("invalid number of builtin uses")]
+    UsesInvalid,
+}

crates/air/src/layout/recursive/autogenerated.rs

@@ -6,9 +6,9 @@ use starknet_crypto::Felt;
 pub fn eval_composition_polynomial_inner(
     mask_values: &[Felt],
     constraint_coefficients: &[Felt],
-    point: Felt,
-    trace_generator: Felt,
-    global_values: GlobalValues,
+    point: &Felt,
+    trace_generator: &Felt,
+    global_values: &GlobalValues,
 ) -> Felt {
     // Compute powers.
     let pow0 = point.pow_felt(
@@ -866,9 +866,9 @@ pub fn eval_oods_polynomial_inner(
     column_values: &[Felt],
     oods_values: &[Felt],
     constraint_coefficients: &[Felt],
-    point: Felt,
-    oods_point: Felt,
-    trace_generator: Felt,
+    point: &Felt,
+    oods_point: &Felt,
+    trace_generator: &Felt,
 ) -> Felt {
     // Compute powers.
     let pow0 = trace_generator.pow(0_u128);

crates/air/src/layout/recursive/global_values.rs

@@ -1,3 +1,4 @@
+use cairovm_verifier_transcript::transcript::Transcript;
 use serde::{Deserialize, Serialize};
 use serde_with::serde_as;
 use starknet_core::serde::unsigned_field_element::UfeHex;
@@ -92,3 +93,16 @@ pub struct InteractionElements {
     #[serde_as(as = "UfeHex")]
     pub diluted_check_interaction_alpha: Felt,
 }
+
+impl InteractionElements {
+    pub fn new(transcript: &mut Transcript) -> Self {
+        Self {
+            memory_multi_column_perm_perm_interaction_elm: transcript.random_felt_to_prover(),
+            memory_multi_column_perm_hash_interaction_elm0: transcript.random_felt_to_prover(),
+            range_check16_perm_interaction_elm: transcript.random_felt_to_prover(),
+            diluted_check_permutation_interaction_elm: transcript.random_felt_to_prover(),
+            diluted_check_interaction_z: transcript.random_felt_to_prover(),
+            diluted_check_interaction_alpha: transcript.random_felt_to_prover(),
+        }
+    }
+}