GRPC #20
Closed
GRPC #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkdud007
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Overall, i'm big fan of this grpc approach! great work
there are some refactor that i don't agree with, and maybe our mental model to view node scope can be different.
Especially regarding the comment on Delegator -> BehaviorHandler part, I have idea to make CLI interface to run the node ( currently it's hardcoded config, priv key and everything :/ ), but it's another scope of change so let's first sync on the changes i suggested on this PR scope and merge on it first ( so that you can also work on grpc interface side -- while i work on cli interface side in parallel ) :)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.