Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl] add bc delegate command #3891

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

dustinxie
Copy link
Member

Description

ioctl node delegate gives the delegates list of a certain epoch, but not every delegate's detailed info.

add a ioctl bc delegate command, like below:

./bin/ioctl bc delegate cpc --endpoint=api.iotex.one:443
{
	name: cpc
	ownerAddress: io1smh0a4ms9fc5p8v9h9l7ffgkekv032hzsdkr9a
	operatorAddress: io16fknjsnhj6m5x2fawu5tqfrk6pr9r9xyz489vk
	rewardAddress: io12mgttmfa2ffn9uqvn0yn37f4nz43d248l2ga85
	totalWeightedVotes: 68963450.120222472655746524
	selfStakeBucketIdx: 12
	selfStakingTokens: 2975349.881825114451272576 IOTX
}

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #3891 (8cfae68) into master (e1f0636) will increase coverage by 0.20%.
The diff coverage is 67.20%.

❗ Current head 8cfae68 differs from pull request most recent head fb52c77. Consider uploading reports for the commit fb52c77 to get more accurate results

@@            Coverage Diff             @@
##           master    #3891      +/-   ##
==========================================
+ Coverage   75.38%   75.58%   +0.20%     
==========================================
  Files         303      328      +25     
  Lines       25923    27818    +1895     
==========================================
+ Hits        19541    21027    +1486     
- Misses       5360     5714     +354     
- Partials     1022     1077      +55     
Impacted Files Coverage Δ
action/protocol/execution/evm/evm.go 43.52% <0.00%> (-2.95%) ⬇️
action/protocol/execution/evm/evmstatedbadapter.go 66.77% <ø> (ø)
action/protocol/poll/consortium.go 0.00% <0.00%> (ø)
action/protocol/poll/staking_committee.go 43.85% <0.00%> (ø)
...tion/protocol/staking/contractstake_bucket_type.go 0.00% <0.00%> (ø)
api/grpcserver.go 86.40% <0.00%> (ø)
api/loglistener.go 25.00% <0.00%> (ø)
api/web3server_marshal.go 93.21% <ø> (ø)
api/websocket.go 5.17% <0.00%> (ø)
blockchain/config.go 74.54% <ø> (ø)
... and 51 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Liuhaai
Copy link
Member

Liuhaai commented Jun 22, 2023

could be integrated into nodedelegate.go as a flag?

@dustinxie
Copy link
Member Author

dustinxie commented Jun 22, 2023

could be integrated into nodedelegate.go as a flag?

don't want to mix into ioctl node delegate, there is already ioctl bc bucket and ioctl bc bucketlist command, so ioctl bc delegate makes sense

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.2% 7.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dustinxie dustinxie merged commit 44692a2 into iotexproject:master Jun 28, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants