[staking] handle typedCandidate registration #3902
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (c) 2023 IoTeX Foundation | ||
| // This source code is provided 'as is' and no warranties are given as to title or non-infringement, merchantability | ||
| // or fitness for purpose and, to the extent permitted by law, all liability for your use of the code is disclaimed. | ||
| // This source code is governed by Apache License 2.0 that can be found in the LICENSE file. | ||
|
|
||
| package staking | ||
|
|
||
| import ( | ||
| "math/big" | ||
|
|
||
| "github.com/iotexproject/iotex-address/address" | ||
| ) | ||
|
|
||
| type ( | ||
| // typedCandidateRegister is the interface that every candidate register action should implement | ||
|
There was a problem hiding this comment. it's a interface used within this package, so should be private |
||
| typedCandidateRegister interface { | ||
| OwnerAddress() address.Address | ||
| OperatorAddress() address.Address | ||
| RewardAddress() address.Address | ||
| Amount() *big.Int | ||
| Duration() uint32 | ||
| AutoStake() bool | ||
| CandidateType() uint32 | ||
| // ExtraData returns the customised data for the candidate | ||
| ExtraData() []byte | ||
| } | ||
|
|
||
| // CandidateType is the type of candidate | ||
| CandidateType uint32 | ||
|
|
||
| // TypedCandidate is the struct of a candidate with type | ||
| TypedCandidate struct { | ||
| Owner address.Address | ||
| Operator address.Address | ||
| Reward address.Address | ||
| Type CandidateType | ||
| SelfStakeBucketIdx uint64 | ||
| // extraData is the customised data for the candidate | ||
| extraData []byte | ||
| } | ||
| ) | ||
|
|
||
| func candidateExtra[T interface{ Deserilized([]byte) error }](c *TypedCandidate, extra T) error { | ||
|
|
||
| return extra.Deserilized(c.extraData) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Copyright (c) 2023 IoTeX Foundation | ||
| // This source code is provided 'as is' and no warranties are given as to title or non-infringement, merchantability | ||
| // or fitness for purpose and, to the extent permitted by law, all liability for your use of the code is disclaimed. | ||
| // This source code is governed by Apache License 2.0 that can be found in the LICENSE file. | ||
|
|
||
| package staking | ||
|
|
||
| import ( | ||
| "github.com/iotexproject/iotex-address/address" | ||
|
|
||
| "github.com/iotexproject/iotex-core/action/protocol" | ||
| ) | ||
|
|
||
| // typedCandidateStateManager is the state manager for typed candidate | ||
| type typedCandidateStateManager struct { | ||
| protocol.StateManager | ||
| } | ||
|
|
||
| func (csm *typedCandidateStateManager) isRegistered(candType CandidateType, operatorAddr address.Address) bool { | ||
| // TODO: implement this | ||
| return false | ||
| } | ||
|
|
||
| func (csm *typedCandidateStateManager) upsert(cand *TypedCandidate) error { | ||
| // TODO: implement this | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is
handleTypedCandidateRegistercalled?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can similar code be shared with
handleCandidateRegisterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handleTypedCandidateRegisterwill be called when introducing a specific register actionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handleTypedCandidateRegisteruses different candidate state storage thanhandleCandidateRegisterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add TODO?