[ioctl] support querying delegate by operator address #3904
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3904 +/- ##
==========================================
+ Coverage 75.38% 76.09% +0.71%
==========================================
Files 303 327 +24
Lines 25923 27833 +1910
==========================================
+ Hits 19541 21179 +1638
- Misses 5360 5563 +203
- Partials 1022 1091 +69
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ioctl/cmd/bc/bcdelegate.go
Outdated
| return nil, output.NewError(output.UndefinedError, "failed to find delegate", nil) | ||
| } | ||
|
|
||
| func getDelegates(cli iotexapi.APIServiceClient, offset, limit uint32) (candidateList *iotextypes.CandidateListV2, err error) { |
There was a problem hiding this comment.
there is already same func getStakingCandidates() in nodedelegate.go
move it to /util so can re-use the code?
ioctl/cmd/bc/bcdelegate.go
Outdated
| defer conn.Close() | ||
| cli := iotexapi.NewAPIServiceClient(conn) | ||
|
|
||
| readCandidatesLimit := 20000 |
There was a problem hiding this comment.
200 works and is maybe better?
| @@ -366,39 +365,3 @@ func getAllStakingCandidates(chainClient iotexapi.APIServiceClient) (candidateLi | |||
| } | |||
| return | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
move to util pkg to reuse it
ioctl/util/chain_api.go
Outdated
| @@ -13,6 +13,7 @@ const ( | |||
| _stakingProtocol = "staking" | |||
| ) | |||
|
|
|||
| // GetStakingBuckets returns staking buckets | |||
There was a problem hiding this comment.
GetStakingCandidates returns ...
|
SonarCloud Quality Gate failed.
|
Description
Fixes #3900
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: