-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] add blob data definition and related API #4379
Conversation
return hashes | ||
} | ||
|
||
func ToProtoSideCar(sidecar *types.BlobTxSidecar) *iotextypes.BlobTxSidecar { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we reuse the type? they look the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we re-used the struct, proto is iotextypes
package
BlobGas() uint64 | ||
BlobGasFeeCap() *big.Int | ||
BlobHashes() []common.Hash | ||
BlobTxSidecar() *types.BlobTxSidecar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be part of the action or part of the envelope, if the returned Action
is not just a payload, but AbstractAction Type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be part of envelope
, there will be a clean-up of the interface in future PR,
this PR is just to unblock other PR
Quality Gate passedIssues Measures |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: