-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] blob hash keep the same with or w/o sidecar #4408
Conversation
action/sealedenvelope.go
Outdated
@@ -94,7 +93,7 @@ func (sealed *SealedEnvelope) calcHash() (hash.Hash256, error) { | |||
} | |||
return rlpSignedHash(tx, signer, sealed.Signature()) | |||
case iotextypes.Encoding_IOTEX_PROTOBUF: | |||
return hash.Hash256b(byteutil.Must(proto.Marshal(sealed.Proto()))), nil | |||
return hash.Hash256b(byteutil.Must(sealed.Envelope.NativeHash())), nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct
1eca798
to
104b223
Compare
@@ -51,6 +53,8 @@ type ( | |||
amountForCost interface{ Amount() *big.Int } | |||
|
|||
gasLimitForCost interface{ GasLimitForCost() } | |||
|
|||
protoForRawHash interface{ ProtoForRawHash() *iotextypes.ActionCore } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove raw
protoForHash interface{ ProtoForHash() *iotextypes.ActionCore }
104b223
to
2345966
Compare
Quality Gate passedIssues Measures |
Description
as title
based on #4409
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: