-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] refactor action #4409
[action] refactor action #4409
Conversation
@@ -86,6 +84,14 @@ type ( | |||
} | |||
) | |||
|
|||
// NewEnvelop creates a new envelope | |||
func NewEnvelop(common TxCommonInternal, payload actionPayload) Envelope { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NewEnvelope()
nonce uint64, | ||
gasLimit uint64, | ||
gasTipCap *big.Int, | ||
gasFeeCap *big.Int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use uint256.Int
?
Quality Gate passedIssues Measures |
Description
two major changes:
FillAction
introduced into actionPayloadType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: