Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockchain] set default config values for blob storage #4411

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dustinxie
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

sonarcloud bot commented Oct 2, 2024

CandidateIndexDBPath string `yaml:"candidateIndexDBPath"`
StakingIndexDBPath string `yaml:"stakingIndexDBPath"`
// deprecated
SGDIndexDBPath string `yaml:"sgdIndexDBPath"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add back since default config.yaml on bootstrap repo has this field

// deprecated
SystemSGDContractAddress string `yaml:"systemSGDContractAddress"`
// deprecated
SystemSGDContractHeight uint64 `yaml:"systemSGDContractHeight"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add back since default genesis.yaml on bootstrap repo has this field

ContractStakingIndexDBPath: "/var/data/contractstaking.index.db",
BlobStoreDBPath: "/var/data/blob.db",
BlobStoreRetentionDays: 20,
BlobPurgeInterval: time.Hour,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enforce 20 days of blob storage

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the implementation of blobstore, we may need to make the following two changes:

  1. Change BlobStoreRetentionDays to BlobStoreRetentionBlocks
  2. instead of deleting blobs every hour in a batch, deleting them when PutBlock is called. Because deleting in a batch may delay PutBlock and cause possible delay to the whole network.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend extra 1 day for enhancing robustness of blobsync, like bsc does

ContractStakingIndexDBPath: "/var/data/contractstaking.index.db",
BlobStoreDBPath: "/var/data/blob.db",
BlobStoreRetentionDays: 20,
BlobPurgeInterval: time.Hour,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the implementation of blobstore, we may need to make the following two changes:

  1. Change BlobStoreRetentionDays to BlobStoreRetentionBlocks
  2. instead of deleting blobs every hour in a batch, deleting them when PutBlock is called. Because deleting in a batch may delay PutBlock and cause possible delay to the whole network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants