-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockchain] set default config values for blob storage #4411
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
CandidateIndexDBPath string `yaml:"candidateIndexDBPath"` | ||
StakingIndexDBPath string `yaml:"stakingIndexDBPath"` | ||
// deprecated | ||
SGDIndexDBPath string `yaml:"sgdIndexDBPath"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add back since default config.yaml
on bootstrap repo has this field
// deprecated | ||
SystemSGDContractAddress string `yaml:"systemSGDContractAddress"` | ||
// deprecated | ||
SystemSGDContractHeight uint64 `yaml:"systemSGDContractHeight"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add back since default genesis.yaml
on bootstrap repo has this field
ContractStakingIndexDBPath: "/var/data/contractstaking.index.db", | ||
BlobStoreDBPath: "/var/data/blob.db", | ||
BlobStoreRetentionDays: 20, | ||
BlobPurgeInterval: time.Hour, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enforce 20 days of blob storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the implementation of blobstore, we may need to make the following two changes:
- Change
BlobStoreRetentionDays
toBlobStoreRetentionBlocks
- instead of deleting blobs every hour in a batch, deleting them when
PutBlock
is called. Because deleting in a batch may delayPutBlock
and cause possible delay to the whole network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend extra 1 day for enhancing robustness of blobsync, like bsc does
ContractStakingIndexDBPath: "/var/data/contractstaking.index.db", | ||
BlobStoreDBPath: "/var/data/blob.db", | ||
BlobStoreRetentionDays: 20, | ||
BlobPurgeInterval: time.Hour, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the implementation of blobstore, we may need to make the following two changes:
- Change
BlobStoreRetentionDays
toBlobStoreRetentionBlocks
- instead of deleting blobs every hour in a batch, deleting them when
PutBlock
is called. Because deleting in a batch may delayPutBlock
and cause possible delay to the whole network.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: