Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix goreleaser not being found #208

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

cakemanny
Copy link
Contributor

@cakemanny cakemanny commented Jul 16, 2024

This fixes goreleaser not being found during the make cross step of the Build and Test workflow, as seen here:

/bin/bash: goreleaser: command not found

https://github.com/iovisor/kubectl-trace/actions/runs/9952012009/job/27492540456#step:10:283

It would have been sufficient to add $GOPATH/bin to the PATH, but instead I use a setup-go step to be consistent with the release workflow, which takes care of this.

Additionally,

  • it replaces the deprecated --rm-dist goreleaser flag with --clean which I spotted while testing
  • it bumps the go version in the release workflow to at 1.19 or higher in order to follow the go.mod file.

Signed-off-by: cakemanny <goldingd89@gmail.com>
@fntlnz
Copy link
Member

fntlnz commented Jul 18, 2024

Thanks @cakemanny 🎉

@fntlnz fntlnz merged commit 42eaafc into iovisor:master Jul 18, 2024
4 checks passed
@cakemanny cakemanny deleted the ci-fix-goreleaser-not-found branch July 18, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants