Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write param value in system model [Merge 1st] #52

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

ipa-rwu
Copy link
Collaborator

@ipa-rwu ipa-rwu commented Feb 27, 2024

@ipa-nhg I add parameter values in system model and ros model

fixes #50

@ipa-rwu ipa-rwu force-pushed the rwu/feature/write_param_value_in_system branch from d003d86 to fe93d32 Compare February 27, 2024 19:15
@ipa-rwu ipa-rwu force-pushed the rwu/feature/write_param_value_in_system branch from fe93d32 to d372102 Compare February 27, 2024 19:36
@ipa-rwu ipa-rwu changed the title Write param value in system model Write param value in system model [Merg 1st] Feb 27, 2024
@ipa-rwu ipa-rwu requested a review from ipa-nhg February 27, 2024 19:43
@ipa-rwu ipa-rwu changed the title Write param value in system model [Merg 1st] Write param value in system model [Merge 1st] Feb 27, 2024
@ipa-nhg
Copy link
Member

ipa-nhg commented Feb 28, 2024

Many thanks @ipa-rwu ! 🥇

It works, I have tested it using the static code analysis for aruco_ros and I obtained:

aruco_ros:
  artifacts:
    single:
      node: single
      publishers:
        'pose':
          type: 'geometry_msgs/msg/PoseStamped'
        'transform':
          type: 'geometry_msgs/msg/TransformStamped'
        'position':
          type: 'geometry_msgs/msg/Vector3Stamped'
        'marker':
          type: 'visualization_msgs/msg/Marker'
        'pixel':
          type: 'geometry_msgs/msg/PointStamped'
      subscribers:
        '/camera_info':
          type: 'sensor_msgs/msg/CameraInfo'
      parameters:
        'marker_size':
          type: Double
          value: 0.05
        'marker_id':
          type: Integer
          value: 300
        'reference_frame':
          type: String
        'camera_frame':
          type: String
        'marker_frame':
          type: String
        'image_is_rectified':
          type: Boolean
          value: true
        'min_marker_size':
          type: Double
          value: 0.02
        'detection_mode':
          type: String

🥳 🥳

@ipa-nhg ipa-nhg merged commit 01248ab into main Feb 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ros model not complete (component)
2 participants