Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action does not work #11

Closed
mishmanners opened this issue Feb 22, 2024 · 4 comments
Closed

Action does not work #11

mishmanners opened this issue Feb 22, 2024 · 4 comments

Comments

@mishmanners
Copy link

I added the file: https://github.com/mishmanners/GitHub-Like-A-Boss/blob/main/.github/workflows/taylorsversion.yml

I opened an issue: mishmanners/GitHub-Like-A-Boss#126

The Action ran: https://github.com/mishmanners/GitHub-Like-A-Boss/actions/runs/7999221934

Error code:

add-label
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@dscho
Copy link

dscho commented Feb 22, 2024

I opened an issue: mishmanners/GitHub-Like-A-Boss#126

That item has number 126, but the workflow (it's not a GitHub Action, it's a GitHub workflow 😉) specifically only targets item number 1989.

@dscho
Copy link

dscho commented Feb 22, 2024

it's not a GitHub Action, it's a GitHub workflow 😉

FWIW that could be easily addressed by turning it into a composite GitHub Action.

@ipc103
Copy link
Owner

ipc103 commented Feb 22, 2024

👋 Hi @mishmanners! As @dscho mentioned, right now the action only updates the title if the number is 1989. I think we can add a config option to change this behavior. The fastest fix fro your case is to delete these lines from your workflow! https://github.com/mishmanners/GitHub-Like-A-Boss/blob/main/.github/workflows/taylorsversion.yml#L40-L42

@ipc103
Copy link
Owner

ipc103 commented Feb 22, 2024

Since this is currently expected behavior, closing in favor of #12

@ipc103 ipc103 closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants