-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hold until 3.6 EOL] Bump min Python version from 3.6.2 to 3.7.2 #260
base: master
Are you sure you want to change the base?
Conversation
@ntninja I'm pretty close on this, but as you can see, I'm having some trouble with the last mile. I ran into two problems:
I feel like I'm close but I need some help to push it across the finish line. |
Holy hell, the build finally "passes" - except for the style linting, which is fixed in #257, and should be merged first. A code review would be much appreciated. |
I would expect this change to get squashed to remove some of my commit noise and silly comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks pretty good overall! As mentioned, Python 3.6 support is still important through so that will have to be added back. Otherwise it's only minor stuff.
16e1cee
to
ca4cbb4
Compare
Build is green after rebase and incorporating code review feedback. It doesn't have the 3.7 -> 3.6 code review feedback yet, which I'll get to once I have a larger block of time available. I'll incorporate smaller code review feedback items as they're posted. |
Awesome! Thank you! Don't overwork yourself or anything (just let me know if you don't feel like finishing something)! 😉 |
1fcafe8
to
21718d7
Compare
21718d7
to
be6be6a
Compare
Transient docker failures on the Windows builds. |
be6be6a
to
7c7822f
Compare
Another transient docker failure on a Windows build. |
7c7822f
to
f6f17c5
Compare
f6f17c5
to
afbf9a0
Compare
Another transient Windows build failure, this time with a link: https://travis-ci.com/github/ipfs-shipyard/py-ipfs-http-client/jobs/497459752 They all looked like this one:
|
afbf9a0
to
0aee783
Compare
4c3aaed
to
d5ad5e8
Compare
d5ad5e8
to
af66802
Compare
af66802
to
a80aae6
Compare
51d0880
to
9e3ef09
Compare
9e3ef09
to
f079bae
Compare
f079bae
to
71bf0d7
Compare
71bf0d7
to
e5121e5
Compare
returns_single_item
andreturns_multiple_items
that were causing a pre-existing build failurefocal
(defaults to Python 3.8) that were running onbionic
(defaults to Python 3.6)There's still quite a few typing warning suppression; this commit doesn't attempt to include a sweeping correction to those. Rather, it gets the library up to Python 3.7, which will make a sweeping correction easier.