Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add configuration scripts for local IPFS server #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c0llab0rat0r
Copy link
Contributor

  • Add scripts to enable experimental features required by functional tests
  • Adjust README

@ntninja
Copy link
Contributor

ntninja commented Apr 10, 2021

I think is may be a misunderstanding here: tox -e py3 will start test/run-tests.py which already starts and configures the IPFS daemon (if in ${PATH}), and also sets up coverage reporting since that is quite annoying to do, before invoking pytest in process with a special plugin for the test_shutdown test.

@c0llab0rat0r
Copy link
Contributor Author

tox -e py3 will start test/run-tests.py which already starts and configures the IPFS daemon `

I didn't see that behavior, I'll take a look again.

@c0llab0rat0r
Copy link
Contributor Author

tox -e py3 will start test/run-tests.py which already starts and configures the IPFS daemon `

I didn't see that behavior, I'll take a look again.

Ok, so the misunderstanding here is that I was running the entire test suite from PyCharm, which doesn't run the shell script referenced by tox - it expects pytest to take care of all fixture and dependency setup and tear down.

https://pypi.org/project/pytest-docker/ is a more generalized solution to this problem that makes test execution more flexible.

@c0llab0rat0r c0llab0rat0r changed the title Add configuration scripts for local IPFS server [wip] Add configuration scripts for local IPFS server Apr 10, 2021
@c0llab0rat0r c0llab0rat0r force-pushed the ipfs-config-script branch 2 times, most recently from a45461c to 843e427 Compare April 15, 2021 01:13
@c0llab0rat0r c0llab0rat0r force-pushed the ipfs-config-script branch 4 times, most recently from 08e6ba2 to 303ab14 Compare May 18, 2021 22:11
* Use Docker to support running functional tests from IDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants