Fix bug with httpx usage - ensure basic auth is set when provided #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests
session will pass authentication parameters on every request, buthttpx
does not. This could be a defect in httpx, based on a review of the httpx code.Because Docker Hub has recently established request rate limits on pulls, pytest skip logic was added to prevent the test from executing when run with Travis. This could be changed if an open source special account was created with Docker Hub, and credentials from that account configured in Travis.
There's also logic to skip the test if run on Windows, because there isn't currently an IPFS docker image that supports Windows.