fix: actually use the size hint in util_windows.go #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Jorropo
force-pushed
the
fix/windows_alloc_hint
branch
2 times, most recently
from
f990071
to
669f34a
Compare
|
Found with @Arlodotexe |
Stebalien
reviewed
Aug 9, 2022
Jorropo
force-pushed
the
fix/windows_alloc_hint
branch
from
669f34a
to
0e5da1c
Compare
Jorropo
force-pushed
the
fix/windows_alloc_hint
branch
from
0e5da1c
to
0134971
Compare
Jorropo
force-pushed
the
fix/windows_alloc_hint
branch
6 times, most recently
from
fcf1a59
to
1aa2ad3
Compare
This code was broken, it computed the size hint to do nothing with it.
Jorropo
force-pushed
the
fix/windows_alloc_hint
branch
from
1aa2ad3
to
5b238b6
Compare
Stebalien
approved these changes
Oct 15, 2023
|
I overlooked it didn't built ... :'( thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was broken, it computed the size hint to do nothing with it.
Found with this profile:
This profile clearly show a pattern of
append's growth.With this new code the only way to
appendis if the size hint undershoot (which would require more data to be written between theSizeandReadcalls). Might be worth apanic("race")or returning an error if that happen ?