Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
More tests for the UNIQUAC model to discard a possible bug with temperature dependence in the Python API. There was
no bug, probably I had committed some dumb mistake when I was using it. More tests don't hurt anyone.
It has nothing to do with the temperature dependence "bug." I have changed the combinatorial term to allow the evaluation of UNIQUAC on a mole vector where some components have a composition of 0. Of course, all tests are working. The derivatives changes are reflected in the documentation too.
I made the Ge_combinatorial and Ge_residual of UNIFAC methods of the type, which seems more correct if you want to evaluate one term only from a user perspective.
I moved all the noisy documentation (equations) of the Ge_combinatorial and Ge_residuals to the user documentation just like UNIQUAC documentation works.
The UNIQUAC changes don't use anymore those derivatives but I made two tests for those functions to preserve coverage.