Fix: Deal with hosts attached to unnumbered links #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlab link augmentation code uses address family from the loopback interface to figure out what to do on old-style unnumbered links. That clearly does not work on hosts that have no loopback interface. This fix enables IPv6 LLA on hosts attached to unnumbered links, hoping someone might eventually figure out whether that makes sense. It also removes 'unnumbered' attribute from the link, as no device configuration template checks it. We'll clean up other references to the 'unnumbered' flag in another commit. Fixes #1692
jbemmel
reviewed
Dec 25, 2024
jbemmel
reviewed
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlab link augmentation code uses address family from the loopback interface to figure out what to do on old-style unnumbered links.
That clearly does not work on hosts that have no loopback interface. This fix enables IPv6 LLA on hosts attached to unnumbered links, hoping someone might eventually figure out whether that makes sense.
It also removes 'unnumbered' attribute from the link, as no device configuration template checks it. We'll clean up other references to the 'unnumbered' flag in another commit.
Fixes #1692