rsa: Adds a signer for PSS and PKCS1#1.5 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
commented
Nov 6, 2023
baloo
force-pushed
the
baloo/rsa-tested
branch
6 times, most recently
from
c74f91d
to
3c1e741
Compare
baloo
commented
Nov 6, 2023
| let mut hasher = Sha256::default(); | ||
|
|
||
| let length = data.len() as u16; | ||
| hasher.update(length.to_be_bytes()); |
There was a problem hiding this comment.
to note: I dropped this. I couldn't find where it was coming from, but that was producing incorrect signatures.
There was a problem hiding this comment.
(and this is a breaking change, but ... this is fixing signatures?)
baloo
force-pushed
the
baloo/rsa-tested
branch
from
3c1e741
to
9f837ad
Compare
baloo
force-pushed
the
baloo/rsa-tested
branch
11 times, most recently
from
b0f92d2
to
2a7c2ca
Compare
baloo
force-pushed
the
baloo/rsa-tested
branch
8 times, most recently
from
526c4f0
to
1ed1207
Compare
baloo
force-pushed
the
baloo/rsa-tested
branch
3 times, most recently
from
fec351d
to
3ff6888
Compare
baloo
force-pushed
the
baloo/rsa-tested
branch
4 times, most recently
from
010bffe
to
be4e76c
Compare
This adds a mockhsm implementation and provides an integration test for both signers.
tony-iqlusion
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mockhsm implementation and provides an integration test for both signers.
This was tested with
usbagainst an hardware yubihsm.