New data structures for nodes #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbielow
requested changes
Feb 13, 2023
cbielow
reviewed
Feb 14, 2023
tree/node.cpp
Outdated
Comment on lines
141
to
145
| void PhyloNode::addLessInfoSeqs(std::string&& seq_name) | ||
| { | ||
| ASSERT(!is_internal_); | ||
| data_.leaf.less_info_seqs_.push_back(std::move(seq_name)); | ||
| } |
There was a problem hiding this comment.
this is a bit of a duplicated interface now.
I could also write node.getLessInfoSeqs().push_back(std::move(seq_name))
Usually its bad design to allow that. Maybe keep this function and make the other const as suggested above.
The user cannot remove elements once they are inserted. That is fine, right?
There was a problem hiding this comment.
Yeah. I prefer setting getLessInfoSeqs() as const and having addLessInfoSeqs() for users to update it
…avoid unnecessary moves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new data structures (and their functions) of phylogenetic nodes