Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to use hyphen and underscore in aliases #4

Merged
merged 6 commits into from
Mar 6, 2018

Conversation

jcavejr
Copy link
Contributor

@jcavejr jcavejr commented Mar 6, 2018

Ex:
goto -r test_alias ~

@iridakos
Copy link
Owner

iridakos commented Mar 6, 2018

Excellent 👍

I will check the functionality manually (till #2 is resolved) and I will merge it asap.

Thank you very much for the contribution.

@iridakos
Copy link
Owner

iridakos commented Mar 6, 2018

When user types the following:

goto -<tab>

we show the list of the available commands. I don't want this functionality to go away.

Can you update your changes so that an alias can't start with a dash(-)?

Thanks!

@jcavejr
Copy link
Contributor Author

jcavejr commented Mar 6, 2018

Should be good to go now!

@iridakos
Copy link
Owner

iridakos commented Mar 6, 2018

Thanks, I fill fix an issue on it (it doesn't allow this a4-rec) and I will merge it.

@iridakos iridakos merged commit 01cdb9a into iridakos:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants