-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.4 Planning & Objectives #196
Comments
It'd be useful for me to complete #190, but the questions about that are mainly how how some error handling / validation should work and how 'clever' it should be (simple works for my usage). |
I think we are almost ready for 2.4.0... |
I've done a quick run with benchmarkdotnet against my own project just reading document properties from a Word document and got this: 2.3 openmcdf release
current master branch
The performance numbers are a tad variable when running on my laptop when the times are so low but the memory allocations have gone down quite a bit. I'll try to give it a run over a larger number of files and for writing to make sure no issues pop out. |
The counterpart ticket to v3 planning... I think we've got a decent amount of performance and correctness fixes in for v2.4. I was wondering what others were thinking about additional tickets for the v2.4 milestone?
I just have one last niggle that's on my mind, and that's to validate stream truncation. i.e. check that sectors are correctly marked as free in the FAT when the length of a stream is reduced (I'm not sure if the expectation is that the length of file should reduce in-line with the last allocated sector?). It looks like it's probably OK, so there might be nothing further to do than just convince myself that it is. Even if the file doesn't shrink automatically, then shrinking by the client seems a reasonable option anyway.
Maybe I could run through with some other analyzers too, and check that there aren't any further warnings that are worth addressing.
Other than that is v2.4.0 pretty much ready to go? 🚀
The text was updated successfully, but these errors were encountered: