Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TEST_PR_13 correctness #180

Conversation

jeremy-visionaid
Copy link
Contributor

GUIDs are value types and cannot be null

GUIDs are value types and cannot be null
@ironfede
Copy link
Owner

ironfede commented Oct 7, 2024

GUIDs are value types and cannot be null

This api was effectively too specific and not generic enough... I cannot remove in 2.x since it's public but it should be fixed and generalized in 3.x. Thanks @jeremy-visionaid

@ironfede ironfede merged commit 29143c1 into ironfede:master Oct 7, 2024
1 check passed
@jeremy-visionaid jeremy-visionaid deleted the fix-pr13-test-correctness branch October 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants