Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and simplify DirectoryEntry validation #181

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix and simplify DirectoryEntry validation #181

merged 2 commits into from
Oct 7, 2024

Commits on Oct 7, 2024

  1. Fix and simplify DirectoryEntry validation 

    Ensure both the root and left sibilings are considered when checking
for duplicate SIDs.

Also, remove redundant lookups.
    @jeremy-visionaid
    jeremy-visionaid committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4a58717 View commit details
    Browse the repository at this point in the history

  2. Throw if root directory entry is invalid

    @jeremy-visionaid
    jeremy-visionaid committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e7919e3 View commit details
    Browse the repository at this point in the history